On Mon, 28 Aug 2023 23:35:56 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Clean up parameters passed to arrayPartition; update the check to load >> library > > make/modules/java.base/Lib.gmk line 240: > >> 238: >> 239: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, >> x86_64)+$(INCLUDE_COMPILER2), true+true+true) >> 240: $(eval $(call SetupJdkLibrary, BUILD_LIB_X86_64, \ > > As this is a C++ lib, consider using g++ for linking by setting: > > TOOLCHAIN := TOOLCHAIN_LINK_CXX Thanks Erik. Will update Lib.gmk to use g++ for linking. > make/modules/java.base/Lib.gmk line 247: > >> 245: LDFLAGS := $(LDFLAGS_JDKLIB) \ >> 246: $(call SET_SHARED_LIBRARY_ORIGIN), \ >> 247: LDFLAGS_linux := -Wl$(COMMA)--no-as-needed, \ > > This is set by default since JDK-8314554. Thanks Erik. Will update Lib.gmk accordingly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1309118874 PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1309118373
