On Tue, 29 Aug 2023 17:00:33 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> make/modules/java.base/Lib.gmk line 240: >> >>> 238: >>> 239: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, >>> x86_64)+$(INCLUDE_COMPILER2), true+true+true) >>> 240: $(eval $(call SetupJdkLibrary, BUILD_LIB_X86_64, \ >> >> As this is a C++ lib, consider using g++ for linking by setting: >> >> TOOLCHAIN := TOOLCHAIN_LINK_CXX > > Thanks Erik. Will update Lib.gmk to use g++ for linking. Please see the linking updated to use g++ in the latest commit. >> make/modules/java.base/Lib.gmk line 247: >> >>> 245: LDFLAGS := $(LDFLAGS_JDKLIB) \ >>> 246: $(call SET_SHARED_LIBRARY_ORIGIN), \ >>> 247: LDFLAGS_linux := -Wl$(COMMA)--no-as-needed, \ >> >> This is set by default since JDK-8314554. > > Thanks Erik. Will update Lib.gmk accordingly. Based on your suggestion, please see the LDFLAGS_linux removed in the latest commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1312061806 PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1312061283
