On Wed, 6 Sep 2023 13:46:01 GMT, Deepa Kumari <d...@openjdk.org> wrote:

> Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , 
> the AIX build process raised complaints about the disk location detection, 
> incorrectly determining that the build wasn't on a local disk. However, a 
> partial fix introduced a new problem, the build process consistently reports 
> that it's on a local disk, even when it's not
> The core problem here seems to be that Bash treats quoted commands as string 
> literals, and it only evaluates them if you use 'eval' directly.
>  The  change ensure that Bash correctly evaluates the **DF** variable as a 
> command.
> 
> Reported Issue : [JDK-8315786](https://bugs.openjdk.org/browse/JDK-8315786)

Why is the argument to `if` quoted in the first place? (I realize I reviewed 
the original change, but I probably wasn't looking that closely as it only 
concerned AIX)

-------------

PR Review: https://git.openjdk.org/jdk/pull/15592#pullrequestreview-1622469804

Reply via email to