On Tue, 12 Sep 2023 16:51:53 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Deepa Kumari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove quotes > > make/autoconf/basic.m4 line 482: > >> 480: # is the same. On older AIXes we just continue to live with a "not >> local build" warning. >> 481: if test "x$OPENJDK_TARGET_OS" = xaix; then >> 482: if ""$DF" -T local > /dev/null 2>&1"; then > > Suggestion: > > if $DF -T local > /dev/null 2>&1; then > > I can't test this, but I don't think the quotes serve any purpose here. @erikj79 Thanks for reviewing. I verified this test and it worked fine. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15592#discussion_r1331584402
