On Wed, 13 Sep 2023 23:02:21 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> 
wrote:

> Could you please have a look at the changes in `DualPivotQuicksort.java` and 
> provide your feedback?

I agree that is much cleaner, glad that worked out. That neatly covers multiple 
element types and Java-based insertion sort algorithms (although I don't know 
why we need two since mixed insertion effectively embeds the other but we don't 
need to address that here).

I recommend embedding the functional interfaces next to the associated methods, 
rather than as auxiliary classes, and also adding `@ForceInline` on `arraySort`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14227#issuecomment-1720264496

Reply via email to