On Fri, 15 Sep 2023 22:11:44 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor the sort and partition intrinsics to accept method references for >> fallback functions > > Hello Paul, > > As suggested, the functional interfaces were moved next to the associated > methods and also added a `@ForceInline` for `arraySort` in the latest commit. > >> I recommend embedding the functional interfaces next to the associated >> methods, rather than as auxiliary classes, and also adding `@ForceInline` on >> `arraySort`. > > Thanks, > Vamsi Hi @vamsi-parasa Why do we need ``if (indexPivot1 != indexPivot2) throw new IllegalArgumentException()``? If you implement logic correctly, you will never throw the exception. It is not business case, when exception makes sence. Therefore, I suggest removing this check. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14227#issuecomment-1722333799
