On Fri, 22 Sep 2023 13:41:50 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Avoid eager use of LibFallback in FallbackLinker static block > > src/java.base/share/classes/java/lang/foreign/Linker.java line 409: > >> 407: * >> 408: * Variadic functions are C functions which can accept a variable >> number and type of arguments. They are declared with a >> 409: * trailing ellipsis ({@code ...}) at the end of the formal parameter >> list, such as: {@code void foo(int x, ...);}. > > Looking at the javadoc - it seems to me that the `;` after the declaration of > `foo` leads to a bit of jarring as it is immediately followed by a period > (`.`). Consider dropping that - or maybe put the declaration in a snippet. Will drop the period ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15103#discussion_r1334604329