On Tue, 10 Oct 2023 15:26:39 GMT, Frederic Thevenet <ftheve...@openjdk.org> 
wrote:

> From what I can tell, the test fails because of an unrelated issue with the 
> "test-prebuilt" target used to run the test by GHA.
> 
> According to the logs for the failed test, path to the symbol folder 
> "/d/a/jdk/jdk/bundles/symbols/jdk-22/fastdebug" is passed explicitly via the 
> env variable `SYMBOLS_IMAGE_DIR`:
> 
> ```
> make test-prebuilt TEST='test/hotspot/jtreg/:tier1_runtime' 
> BOOT_JDK=/d/a/jdk/jdk/bootjdk/jdk JT_HOME=jtreg/installed 
> JDK_IMAGE_DIR=/d/a/jdk/jdk/bundles/jdk/jdk-22/fastdebug 
> SYMBOLS_IMAGE_DIR=/d/a/jdk/jdk/bundles/symbols/jdk-22/fastdebug 
> TEST_IMAGE_DIR=/d/a/jdk/jdk/bundles/tests 
> JTREG='JAVA_OPTIONS=-XX:-CreateCoredumpOnCrash;VERBOSE=fail,error,time;KEYWORDS=!headful'
> ```
> 
> But looking into the hs_err report, we see the path for the symbols folder is 
> not considered by the symbol engine:
> 
> ```
> symbol engine: initialized successfully - sym options: 0x614 - pdb path: 
> .;D:\a\jdk\jdk\bundles\jdk\jdk-22\fastdebug\bin;C:\Windows\SYSTEM32;C:\Windows\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.17763.4851_none_de72d1b65349cfc4;D:\a\jdk\jdk\bundles\jdk\jdk-22\fastdebug\bin\server
> ```
> 
> That would still imply that the pdb files were stripped from the jdk bundle 
> that is uploaded by the build task, or they would be picked by the symbol 
> engine from there. Right now, I don't know if this is indeed the case, and if 
> so caused by the renaming of pdb files in this PR.

I must confess that I'm not very well versed in the github actions 
configuration and execution model, nor our implementation. In our internal 
build-and-test system, we provide `SYMBOLS_IMAGE_DIR` as an env variable when 
invoking `test-prebuilt`, and the test passes in this setup. From your 
description it seems our GHA are supposed to be setup in the same way, but 
maybe there is a bug in there somewhere.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16039#issuecomment-1755779934

Reply via email to