On Tue, 10 Oct 2023 16:52:52 GMT, Frederic Thevenet <ftheve...@openjdk.org> wrote:
> All that to say that it looks like there might be a bug in ` test-prebuilt` > (which doesn't mean there couldn't be one GHA too, of course...) > > Apologies if I'm just shooting in the dark here, but at a cursory glance, I > notice that in RunTestsPrebuilt.gmk, SYMBOLS_IMAGE_DIR isn't checked for > validity like JDK_IMAGE_DIR or TEST_IMAGE_DIR are; do you know why that is? > Although from what I understand, it wouldn't transform the path, it would > have caught the problem, wouldn't it? > > https://github.com/openjdk/jdk/blob/80232b7e753129ca7a4f1ca9b70844e0c7d8eabf/make/RunTestsPrebuilt.gmk#L121C9-L124 We aren't checking SYMBOLS_IMAGE_DIR because we consider it optional. Tests are expected to be able to run without it, you just get less information on crashes. _NT_SYMBOL_PATH is setup with Windows style paths based on SYMBOLS_IMAGE_DIR here: https://github.com/openjdk/jdk/blob/80232b7e753129ca7a4f1ca9b70844e0c7d8eabf/make/RunTests.gmk#L63 In our run-test-prebuilt scenario, our JDK_IMAGE_DIR does not have any pdb files. The _NT_SYMBOLS_PATH setup was introduced to provide pdb files for symbol lookup in hs_err files, so I'm fairly certain that part works. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16039#issuecomment-1755913155
