On Wed, 11 Oct 2023 17:28:12 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> The goal of this PR is to address the follow-up comments to the SIMD >> accelerated sort PR (#14227) which implemented AVX512 intrinsics for >> Arrays.sort() methods. >> The proposed changes are: >> >> 1) Restriction of the AVX512 sort acceleration to only Intel CPUs. A >> performance regression (due to micro-architectural differences) was reported >> for AMD Zen4 CPUs in the comments section of PR. >> 2) Addressing the build failure due to a bug in GCC 12 (which was fixed in >> version 12.3.1). The details of the bug are at: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105593 >> 3) Minor changes in Javadoc strings > > Srinivas Vamsi Parasa has updated the pull request incrementally with one > additional commit since the last revision: > > Add @ForceInline annotation to insertion and mixedInsertion sort make/modules/java.base/Lib.gmk line 230: > 228: CFLAGS := $(CFLAGS_JDKLIB) $(LIBFFI_CFLAGS), \ > 229: LDFLAGS := $(LDFLAGS_JDKLIB) \ > 230: $(call SET_SHARED_LIBRARY_ORIGIN), \ If you are going to fix the indentation here, please do it to follow the code conventions for the build system: https://openjdk.org/groups/build/doc/code-conventions.html 2. If a line must be broken, use four spaces for indentation. 18. Avoid padding internally in a line with spaces to try to align some feature into columns with surrounding lines. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16124#discussion_r1355763767
