On Wed, 11 Oct 2023 20:48:06 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add @ForceInline annotation to insertion and mixedInsertion sort > > make/modules/java.base/Lib.gmk line 230: > >> 228: CFLAGS := $(CFLAGS_JDKLIB) $(LIBFFI_CFLAGS), \ >> 229: LDFLAGS := $(LDFLAGS_JDKLIB) \ >> 230: $(call SET_SHARED_LIBRARY_ORIGIN), \ > > If you are going to fix the indentation here, please do it to follow the code > conventions for the build system: > https://openjdk.org/groups/build/doc/code-conventions.html > > 2. If a line must be broken, use four spaces for indentation. > 18. Avoid padding internally in a line with spaces to try to align some > feature into columns with surrounding lines. Hi Erik (@erikj79), BUILD_LIBFALLBACKLINKER is from different PR (#13079). If I understand correctly, for LIB_SIMD_SORT, are you suggesting that we don't pad the lines with spaces to align features into columns and instead just use 4 spaces for the indentation after the line break? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16124#discussion_r1355779727
