On Fri, 20 Oct 2023 19:18:47 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
> Hello, > > In this PR I removed NSS tests from the ProblemList and updated NssTest to > use Sqlite databases. I also removed code in PKCS11Test.java that falls back > to NSS libraries installed on the test system. The tests can still be run > with different NSS libraries but they have to be specified by a system > property. I updated `doc/testing.md` to reflect that change. > > Thanks doc/testing.md line 605: > 603: correctly, the system property `jdk.test.lib.artifacts.<NAME>` is > required on Ubuntu 18.04 > 604: to specify the alternative NSS lib directories. The `<NAME>` component > should be replaced > 605: with the name of the appropriate `@Artfact` class. (See > `test/jdk/sun/security/pkcs11/PKCS11Test.java`) Could you please adjust the line length to match the surrounding text. When changing any `doc/*.md` file, you will need to regenerate the corresponding html files and include that update in the commit. This can be done with the following make target if you have an appropriate pandoc configured. make update-build-docs ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1367499783
