On Tue, 24 Oct 2023 19:58:58 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> Hello, >> >> In this PR I removed NSS tests from the ProblemList and updated NssTest to >> use Sqlite databases. I also removed code in PKCS11Test.java that falls back >> to NSS libraries installed on the test system. The tests can still be run >> with different NSS libraries but they have to be specified by a system >> property. I updated `doc/testing.md` to reflect that change. >> >> Thanks > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: > > fixed whitespace errors doc/testing.html line 582: > 580: correctly, the system property > 581: <code>jdk.test.lib.artifacts.<NAME></code> is required on Ubuntu > 582: 18.04 to specify the alternative NSS lib directories. The directory if allowing only single value. doc/testing.html line 584: > 582: 18.04 to specify the alternative NSS lib directories. The > 583: <code><NAME></code> component should be replaced with the name > 584: element of the appropriate<code>@Artfact</code> class. (See typo: Artifact doc/testing.md line 604: > 602: on Ubuntu 18.04 with the default NSS version in the system. To run these > tests > 603: correctly, the system property `jdk.test.lib.artifacts.<NAME>` is > required on > 604: Ubuntu 18.04 to specify the alternative NSS lib directories. The `<NAME>` If only single value is allowed for the system property, should it be "directory" instead of "directories"? doc/testing.md line 605: > 603: correctly, the system property `jdk.test.lib.artifacts.<NAME>` is > required on > 604: Ubuntu 18.04 to specify the alternative NSS lib directories. The `<NAME>` > 605: component should be replaced with the name element of the > appropriate`@Artfact` typo: Artifact test/jdk/sun/security/pkcs11/README line 10: > 8: The system property, jdk.test.lib.artifacts.<NAME>, can specify an > absolute path > 9: to the local NSS library directory. The <NAME> component should be > replaced with > 10: the name element of the appropriate @Artfact class. typo: Artifact test/jdk/sun/security/pkcs11/README line 14: > 12: > 13: 2. Pre-built NSS libraries from artifactory server > 14: If the value of system property test.nss.lib.paths is not set, the tests > will try So, do we still support the "test.nss.lib.paths" system property? Or should the above comment be updated as well? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1399904586 PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1399904251 PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1399903808 PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1399902987 PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1399901453 PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1399902059
