On Wed, 8 Nov 2023 17:32:41 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> make/hotspot/lib/CompileJvm.gmk line 92: >> >>> 90: >>> 91: ifeq ($(DEBUG_LEVEL), fastdebug) >>> 92: ifeq ($(call And, $(call isTargetOs, linux) $(call isTargetCpu, >>> aarch64)), true) >> >> The idiomatic way we have expressed this in other places in the JDK build is: >> Suggestion: >> >> ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, aarch64), true+true) > > FWIW I just followed the preexisting pattern in the same file, e.g. > https://github.com/openjdk/jdk/blob/7d25f1c6cb770e21cfad8096c1637a24e65fab8c/make/hotspot/lib/CompileJvm.gmk#L1100. > @magicus Let me know if you want me to change it. > [T]he And macro was actually added by you Oh. 😊 Ohh... That was a bit stupid of me, then. :) But I just checked, I found 4 cases of `$(call And)` vs 11 cases of using `+` in our makefiles. So it is a clear overweight for the `+` syntax, but is not the sole pattern as I thought. So yes, it is okay to keep it as it is. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16550#discussion_r1387221051
