On Mon, 13 Nov 2023 17:55:12 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> Oracle is updating the version of GCC for building the JDK on Linux to >> 13.2.0. >> >> >> **Note: The changes discussed below were broken out into a separate change >> and integrated through #16584.** >> >> Apart from the "obvious" changes, I'll add some color to the CompileJvm.gmk >> changes. In particular, I ran into two different types of new warnings with >> GCC 13.2.0: >> >> 1. linux-aarch64-debug + stringop-overflow >> >> `src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp:203:66: error: >> 'long unsigned int __atomic_load_8(const volatile void*, int)' writing 8 >> bytes into a region of size 0 overflows the destination >> [-Werror=stringop-overflow=]` >> >> Only reproduces with fastdebug on linux-aarch64. I tried to understand why >> the warning is generated and how the code could be fixed but eventually had >> to give up.. I ended up disabling the warning for linux-aarch64-debug >> specifically but open to feedback and other alternatives. >> >> 2. linux + zero + dangling-pointer >> >> >> `src/hotspot/share/runtime/thread.hpp:579:77: error: storing the address of >> local variable 'rm' in '*_thr_current.Thread::_current_resource_mark' >> [-Werror=dangling-pointer=]` >> >> The linux/zero build generates lots and lots of dangling pointer warnings. >> As with the first warning I tried to understand why but also gave up in the >> end. Like the first warning I disabled it instead, for zero builds. Again >> appreciating feedback/suggestions. > > Mikael Vidstedt has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8319570-gcc-13.2.0 > - Update copyright years > - Move ASSERT ResourceMark constructor to resourceArea.cpp to avoid dangling > pointer warning with zero > - 8319570: Change to GCC 13.2.0 for building on Linux at Oracle Thank you for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/16550#issuecomment-1809251421
