On Fri, 10 Nov 2023 07:54:40 GMT, suchismith1993 <d...@openjdk.org> wrote:

> Which directory do you suggest to put the exports list in ? Do we create a 
> new directory or use any existing directory.

My initial thinking is like Erik's, that this list should be dynamically 
generated at build-time. I am pretty sure that anything but doing that will end 
up with hard-to-debug problems in the future. At build-time, you know exactly 
what symbols you are linking with.

If this, for some reason, is infeasible, then we can discuss how to 
generate/update such a list, and where to put it. If the list needs to be 
manually generated ahead-of-time of the build, then this should ideally be done 
by a script that is checked in. If manual intervention/curation is needed, then 
this needs to be properly documented.

Just pushing a list like this, with no explanation, is not going to cut it, 
regardless of where in the source code tree it is stored.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16414#issuecomment-1805972829

Reply via email to