On Fri, 19 Jan 2024 10:37:42 GMT, Sam James <d...@openjdk.org> wrote:
>> The LFS64 symbols provided by glibc are not part of any standard and were >> gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in 1.2.5). >> This commit replaces the usage of LFS64 symbols with their regular >> counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions >> will always act as their -64 variants on glibc. > > Sam James has updated the pull request incrementally with two additional > commits since the last revision: > > - sendfile64 -> sendfile > > Signed-off-by: Sam James <s...@gentoo.org> > - buf64->buf > > Signed-off-by: Sam James <s...@gentoo.org> Looks good to me, but please also adjust COPYRIGHT headers (e.g. flags-cflags.m4) . Btw. I can confirm that with your patch applied, the build is fixed on Alpine 3.19 (see also [JDK-8324153](https://bugs.openjdk.org/browse/JDK-8324153) build fails on Alpine x86_64 3.19 for details on the failures) . ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16329#pullrequestreview-1832719082
