On Sat, 20 Jan 2024 10:15:02 GMT, Sam James <d...@openjdk.org> wrote:
> This fixes building with GCC 14: > * ~Cherry-pick a fix from Harfbuzz upstream~ > * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources > > -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses > -Werror. > > The calloc prototype is: > > void *calloc(size_t nmemb, size_t size); > > > So, just swap the number of members and size arguments to match the > prototype, as > we're initialising 1 struct of size `sizeof(struct ...)`. GCC then sees we're > not > doing anything wrong. This pull request has now been integrated. Changeset: 8e5f6ddb Author: Sam James <s...@gentoo.org> Committer: Julian Waters <jwat...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/8e5f6ddb68572c0cc8b6e256e423706f6f7cec94 Stats: 6 lines in 4 files changed: 2 ins; 0 del; 4 mod 8324243: Compilation failures in java.desktop module with gcc 14 Reviewed-by: jwaters, ihse, kbarrett, prr ------------- PR: https://git.openjdk.org/jdk/pull/17506
