On Thu, 22 Feb 2024 16:28:20 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been > integrated, it is possible to do some cleanup. The goal of > [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change > any behavior, even if that behavior seemed odd. > > Now let's try to fix that. We can: > > a) remove JNIEXPORT from c2v functions. > b) make debug.cpp functions exported similarly on all platforms. > c) remove JNIEXPORT from aarch64 asm debug function. > > Note that this PR is [dependent > on](https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html) > https://github.com/openjdk/jdk/pull/17955. src/hotspot/cpu/aarch64/assembler_aarch64.cpp line 122: > 120: } > 121: > 122: void das1(uintptr_t insn) { Doesn't this need to be exported for debugging on Windows-Aarch64? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1500001316
