On Thu, 22 Feb 2024 09:59:48 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> they were absent from .dynsym but available in .symtab as bind: local, >> visibility: default. Now they are completely gone. >> >> The symbols were supposed to be used from gdb. I'm not sure if gdb can >> access local symbols, so it's possible that they didn't work even before >> this change. > >> But for platform consistency, it might make sense to export these even on >> gcc as well. > > JDK-8288293 would definitely like that a lot Thanks - when I last tried, e.g. "call universe()" would work on Linux/gdb, so I think gdb did resolve a local symbol (which cannot be found by callling dlsym, but can be found in the binary symboltable). On Windows the debug.cpp symbols just weren't in the binary at all, then with JDK-8264593 JNIEXPORT they were, and appeared in the .map file we generate also. So I am saying I added the JNIEXPORT for Windows, to get the debug.cpp symbols into the binary. This removes JNIEXPORT for gcc, which already had the debug.cpp symbols in the binary. But I will go check this... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17955#discussion_r1499086833
