On Thu, 22 Feb 2024 07:50:34 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Thanks for doing this! This is a good improvement IMO. Thanks! > If the `SUNWprivate_1.1` part of the symbols is still needed, it can be added > using `--default-symver` ld parameter. Ah, good to know. In the spirit of making as minimal changes as possible in this PR, I will add it. > You might want to run tier1-5 tests; compilation-related changes are often > detected by higher-level builds and tests only. I can run tier 4 and 5 also. But once again, the entire point of this PR being so convoluted is that there should be a minimum of differences in compilation. On macOS and Windows, the binaries before and after this patch are almost identical; just a few hundred assembler instructions have been reordered slightly. (Why this is even so I don't know, but in the end I did not care to dig into the details.) On Linux, more code is shuffled around, making for a greater bit-by-bit difference. Still, the symbol tables are (almost) identical, and these changes should only affect symbol visibility, so I believe this is mostly an artifact of how the linker organises stuff. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17955#issuecomment-1959051714
