On Thu, 22 Feb 2024 09:26:23 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> I tried to be clear, but apparently I failed: There is no change to these > symbols in the patch! So everything should work just as before! Yes but "should work" and "does work" may not be the same unless you have actually verified the functionality. That said I now see that we only actually need to export on Windows for the debugging functions to work, so I agree everything should work just fine in that regard. Apologies - It took me a little while to click to the fact not all JNIEXPORT symbols were actually being exported due to their omission in the mapfile - hence the need to now actually hide them to keep things working the same. (FWIW I don't think it matters if we export the debug functions unnecessarily on some platforms - I'd go for code simplicity/consistency. EDIT and I see you went that way too.) ------------- PR Comment: https://git.openjdk.org/jdk/pull/17955#issuecomment-1960416613
