On Thu, 22 Feb 2024 09:30:30 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/hotspot/lib/CompileJvm.gmk line 149: >> >>> 147: >>> 148: ifeq ($(call isTargetOs, windows), true) >>> 149: WIN_EXPORT_FILE := $(JVM_OUTPUTDIR)/win-exports.txt >> >> Why not .def? > > I try to stick to established file suffixes if possible. I have never heard > of .def before, but maybe that is a standard name for these kinds of files on > Windows? If so, I will change it. The -def option is for accepting definition files, which are usually suffixed with .def. See for instance https://github.com/openjdk/jdk/blob/10eafdc62e8216e6ef69773fe491a21346c8682d/make/modules/jdk.accessibility/Lib.gmk#L80 .def file contents typically look like this: https://github.com/openjdk/jdk/blob/master/src/jdk.accessibility/windows/native/libwindowsaccessbridge/WinAccessBridge.DEF The Microsoft documentation for them is here: https://learn.microsoft.com/en-us/cpp/build/reference/module-definition-dot-def-files?view=msvc-170 If the contents of WinAccessBridge.def look similar enough to the Windows exports file that is created from the dumpbin object file process, feel free to rename it ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17955#discussion_r1498963562
