On Thu, 22 Feb 2024 16:28:20 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been > integrated, it is possible to do some cleanup. The goal of > [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change > any behavior, even if that behavior seemed odd. > > Now let's try to fix that. We can: > > a) remove JNIEXPORT from c2v functions. > b) make debug.cpp functions exported similarly on all platforms. > c) remove JNIEXPORT from aarch64 asm debug function. > > Note that this PR is [dependent > on](https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html) > https://github.com/openjdk/jdk/pull/17955. Nice cleanup! src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 1027: > 1025: > 1026: extern "C" { > 1027: VMStructEntry* jvmciHotSpotVMStructs = > JVMCIVMStructs::localHotSpotVMStructs; All these globals are unused now. You can remove them. ------------- PR Review: https://git.openjdk.org/jdk/pull/17967#pullrequestreview-1897492946 PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1500284610
