On Mon, 26 Feb 2024 22:11:31 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing review comments > > src/java.base/share/classes/sun/util/locale/provider/FallbackLocaleProviderAdapter.java > line 86: > >> 84: @Override >> 85: // In order to correctly report supported locales >> 86: public BreakIteratorProvider getBreakIteratorProvider() { > > More for my understanding but I am curious why FallbackLocaleProviderAdapter > has to override `getBreakIteratorProvider`, but can rely on the > `getCollatorProvider` from JRELocaleProviderAdapter? Also wondering why > "BreakIteratorRules" is fetched when JRELocaleProviderAdapter fetches > "FormatData" if the data is the same COMPAT data. `COMPAT` used to offer supported locales for the ones that exist as resource bundles. For `Collator`, `JRELocaleProviderAdapter` had a list for `CollationData` resource bundles, but `BreakIterator` shared with `FormatData`, which now only has root/en/ja (for Gan-nen support). So it had to override the method and return `th` (this is the main function for `BreakIterator` as of now) > test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 30: > >> 28: * Tests both COMPAT and CLDR data. >> 29: * @modules jdk.localedata >> 30: * @run junit/othervm -Djava.locale.providers=COMPAT CurrencyFormat > > The methods `currencySymbolsTest`, `currencySymbolsDataProvider`, and > `getFutureSymbol` can be removed since they are for COMPAT only. > > The string array `expectedCOMPATData` can be removed from the data provider > method `currencyFormatDataProvider` as well as `isCompat` variable and usage. > > _CurrencySymbols.properties_ can also be deleted since that is what > `currencySymbolsDataProvider` uses to build the data and no other tests rely > on the file. Good catch! Removed `COMPAT` related tests/data. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17991#discussion_r1503478694 PR Review Comment: https://git.openjdk.org/jdk/pull/17991#discussion_r1503478605