On Tue, 5 Mar 2024 06:44:52 GMT, Joe Wang <jo...@openjdk.org> wrote:

>> Naoto Sato has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains 44 additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8174269-COMPAT-Removal
>>  - Addressing review comments
>>  - Update test/jdk/java/text/Format/DateFormat/Bug6683975.java
>>    
>>    Co-authored-by: Justin Lu <justin...@oracle.com>
>>  - Remove `GensrcLocaleData.gmk`
>>  - Update make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java
>>    
>>    Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>>  - cleanup
>>  - BreakIteratorProvider available locales fix
>>  - clean-up
>>  - test fixes
>>  - makeZoneData.pl fix
>>  - ... and 34 more: https://git.openjdk.org/jdk/compare/7faf5495...b771e303
>
> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1320:
> 
>> 1318:      * "US<NBSP>dst" -> "D"
>> 1319:      *
>> 1320:      * `tzdbLinks` retains `Link`s of time zones. if the value
> 
> nit, "if the value" seems to be an unfinished sentence.

Thanks. Not only the sentence, the description itself was unfinished. Corrected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17991#discussion_r1513248212

Reply via email to