This Message Is From an External Sender
This message came from outside your organization.
On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only handle it properly on Windows. We need to bring it up to the same levels as product code. This is a prerequisite for [JDK-8327045](https://bugs.openjdk.org/browse/JDK-8327045), which in turn is a building block for Hermetic Java.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> Update line number for dereference_null in TestDwarf
Thanks, this looks good to me.
test/jdk/java/foreign/CallGeneratorHelper.java line 216:
> 214: if (header) {
> 215: System.out.println(
> 216: "#include \"export.h\"\n"
We don't generate these header files any more, so the changes to this file are not really needed.
-------------
Marked as reviewed by jvernee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18135#pullrequestreview-1925503653
PR Review Comment: https://git.openjdk.org/jdk/pull/18135#discussion_r1518086954
