On Tue, 12 Mar 2024 13:51:28 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> test/jdk/java/foreign/CallGeneratorHelper.java line 216:
>>
>>> 214: if (header) {
>>> 215: System.out.println(
>>> 216: "#include \"export.h\"\n"
>>
>> We don't generate these header files any more, so the changes to this file
>> are not really needed.
>
> I still wouldn't like to keep the bad hard-coded defines. Are you okay with
> me pushing these changes, and then you can remove the parts of the test that
> are not actually used anymore? If the code is not used it should not matter
> much to you either way.
>
> (I mean I could back out these changes, but then we'd have the bad code in
> place while waiting for you to remove it, putting pressure on you to actually
> remove it.)
Yes, that's fine. Sorry, I meant to file a JBS issue and come back with another
comment last time, but I got distracted. Filed:
https://bugs.openjdk.org/browse/JDK-8327994 now
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18135#discussion_r1521715617
