On Wed, 27 Mar 2024 12:00:28 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This is a follow-up on JDK-8328680, making the same kind of cleanup to > jdk.accessibility. The code here needed more work than for the other modules, > so I wanted have it in a separate PR to get a more thorough review. make/modules/jdk.accessibility/Launcher.gmk line 70: > 68: LIBS_windows := advapi32.lib user32.lib, \ > 69: VERSIONINFO_RESOURCE := \ > 70: > $(ACCESSIBILITY_SRCDIR)/jaccessinspector/jaccessinspectorWindow.rc, \ Should we increase relative indentation to 4? make/modules/jdk.accessibility/Launcher.gmk line 95: > 93: LIBS_windows := advapi32.lib comctl32.lib gdi32.lib user32.lib, \ > 94: VERSIONINFO_RESOURCE := \ > 95: $(ACCESSIBILITY_SRCDIR)/jaccesswalker/jaccesswalkerWindow.rc, \ Indentation 4? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18510#discussion_r1541573987 PR Review Comment: https://git.openjdk.org/jdk/pull/18510#discussion_r1541575150
