On Wed, 27 Mar 2024 18:20:47 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> This is a follow-up on JDK-8328680, making the same kind of cleanup to >> jdk.accessibility. The code here needed more work than for the other >> modules, so I wanted have it in a separate PR to get a more thorough review. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix incorrect indentation make/modules/jdk.accessibility/Launcher.gmk line 30: > 28: ifeq ($(call isTargetOs, windows), true) > 29: ACCESSIBILITY_SRCDIR := $(TOPDIR)/src/jdk.accessibility/windows/native > 30: It looks like you determined that these aren't all needed in most cases ? Since I don't see them being passed to the various builds any more. jabswitch I'm sure won't need these but I'm a bit more surprised by the others .. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18510#discussion_r1541833416
