On Thu, 4 Apr 2024 16:02:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This patch will fix the few remaining places where a "raw" call to > SetupNativeCompilation was made, instead of going via > SetupJdkNativeCompilation. This include repairing the poor old X11Wrapper, > which has been broken for some time. > > After this we can finally make SetupNativeCompilation an "inner macro" of > SetupJdkNativeCompilation, and stop exposing two different ways of compiling > native code. > > I have also added standard header comments to some places where I have missed > it, and corrected an incorrect indentation (all things I found while > double-checking all SetupJdkNativeCompilation calls). Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/18631#pullrequestreview-1980539107