On Thu, 4 Apr 2024 16:02:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This patch will fix the few remaining places where a "raw" call to > SetupNativeCompilation was made, instead of going via > SetupJdkNativeCompilation. This include repairing the poor old X11Wrapper, > which has been broken for some time. > > After this we can finally make SetupNativeCompilation an "inner macro" of > SetupJdkNativeCompilation, and stop exposing two different ways of compiling > native code. > > I have also added standard header comments to some places where I have missed > it, and corrected an incorrect indentation (all things I found while > double-checking all SetupJdkNativeCompilation calls). This pull request has now been integrated. Changeset: 3f4b167c Author: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/3f4b167c974881f5f7ea1c621c7efe2f550cb60c Stats: 122 lines in 15 files changed: 57 ins; 23 del; 42 mod 8329672: Only call SetupNativeCompilation from SetupJdkNativeCompilation Reviewed-by: erikj ------------- PR: https://git.openjdk.org/jdk/pull/18631