On Thu, 4 Apr 2024 22:47:18 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> This is a retake on https://github.com/openjdk/jdk/pull/15096. >> >> I tried to fix the remaining issues in that PR, but could not push them. In >> the end, it seemed easier to create a new branch in my own personal fork. >> >> The majority of the work in this PR has been done by @TheShermanTanker. I >> have stepped in and fixed the remaining comments, reverted some additional >> unneeded changed code, and also tried to minimize code duplication in >> `awt_PrintJob.cpp`. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into awt-permissive-minus > - 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft > Visual C compiler src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 6370: > 6368: AwtComponent *awtParent = NULL; > 6369: > 6370: if (self == NULL) { I had missed this in my earlier sweep of the changes, but didn't Phil request that both the check for self and parent be merged into self == NULL || parent == NULL? (Or as I'd prefer, nullptr) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18584#discussion_r1552961774
