On Fri, 5 Apr 2024 05:48:40 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains two >> additional commits since the last revision: >> >> - Merge branch 'master' into awt-permissive-minus >> - 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft >> Visual C compiler > > src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 6370: > >> 6368: AwtComponent *awtParent = NULL; >> 6369: >> 6370: if (self == NULL) { > > I had missed this in my earlier sweep of the changes, but didn't Phil request > that both the check for self and parent be merged into self == NULL || parent > == NULL? (Or as I'd prefer, nullptr) I noticed Phil's comment, but I could not make it look nice. For instance, the NPE error message was unclear, and you could not see the connection between self->awtComponent and parent->awtParent, which was obvious in the original code. In the end, I thought it was preferable to use the exact same style when expanding the macro as elsewhere. That creates a common pattern across the codebase. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18584#discussion_r1553174771