On Wed, 10 Apr 2024 21:10:27 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> This is the pinnacle of the recent stream of refactorings in the build 
>> system. This patch introduces a more abstract concept of "JDK_LIBS", where 
>> only the library name (e.g. "java" or "java.desktop:jawt") is specified, and 
>> the build system turns this into suitable linker flags: `-ljawt -L<correct 
>> path>` or `jawt.lib -libpath:<correct path>`, depending on linker. It will 
>> also automatically create proper dependencies.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix missing lib prefix

No worries, I can clean it up on my end, since it's not that big of a change. I 
just needed to know whether the LIBPATH pointed to the import library or 
library itself when linking (Also another question, AddJdkLibrary _is_ what 
adds the library path and library itself to the LDFLAGS and LIBS respectively, 
right?)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18649#issuecomment-2056094573

Reply via email to