On Wed, 10 Apr 2024 21:10:27 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> This is the pinnacle of the recent stream of refactorings in the build >> system. This patch introduces a more abstract concept of "JDK_LIBS", where >> only the library name (e.g. "java" or "java.desktop:jawt") is specified, and >> the build system turns this into suitable linker flags: `-ljawt -L<correct >> path>` or `jawt.lib -libpath:<correct path>`, depending on linker. It will >> also automatically create proper dependencies. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix missing lib prefix > (Also another question, AddJdkLibrary is what adds the library path and > library itself to the LDFLAGS and LIBS respectively, right?) Yes. I was hoping that would be rather clearly documented... Any way, my plan is to make a clear separate directory `import-libs` or something like that, so we can clearly separate import libraries from "proper" static libraries, which is not really done right now. I think and hope that after I'm done, everything will be much clearer, so whatever changes you need to do are obvious and simple. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18649#issuecomment-2056641541
