On Mon, 15 Apr 2024 12:34:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> Instead of executing code directly in Link.gmk, we set variables that are 
> then evaluated to get the code we want. This is non-transparent and makes it 
> unnecessarily hard to work with the linking code base. 
> 
> This PR also contains some additional code cleanup/fixes.

The indentation for the first line after ExecuteWithLog is done with 2 spaces 
everywhere in this patch, but as that's a macro call it should be 4, right? 
Looks like we usually do 4 in other places.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18783#pullrequestreview-2001028930

Reply via email to