On Mon, 15 Apr 2024 12:54:22 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> The indentation for the first line after ExecuteWithLog is done with 2 spaces > everywhere in this patch, but as that's a macro call it should be 4, right? > Looks like we usually do 4 in other places. Good catch! I checked some other places with ExecuteWithLog. We do consistently use 4 spaces (except two places for static linking; I fixed those) for the first line. However, we have not really been consistent in how we have treated multi-line commands. Usually we break them with 4 spaces additional indentation, but when they are seen as individual commands we have not always done so. Maybe we should do a pass over the code base at some point to make sure we are consistent. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18783#issuecomment-2056899777
