On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> The file to build most of the java.desktop native libraries, >> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate. >> >> I want to split it into two parts, one for the AWT libraries, and one for >> the 2D libraries. I also used this opportunity to change the order to be >> more logical (e.g. grouping "image" libraries and "font" libraries in 2D). > > Magnus Ihse Bursie has updated the pull request incrementally with two > additional commits since the last revision: > > - Make the split based on the name "awt" instead, and document the reason > - Rename 2dLibraries.gmk to ClientLibraries.gmk And just to put some perspective here: The .gmk files for all other modules are at an average of 2 kB. The Awt2dLibraries.gmk file is 32 kB. Even with the split the two remaining parts will be 16 kB, which is still larger than the next biggest file (java.base/gensrc/GensrcBuffer.gmk) at 14 kB. So this is really an outlier. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18743#issuecomment-2059720604
