On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> The file to build most of the java.desktop native libraries, >> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate. >> >> I want to split it into two parts, one for the AWT libraries, and one for >> the 2D libraries. I also used this opportunity to change the order to be >> more logical (e.g. grouping "image" libraries and "font" libraries in 2D). > > Magnus Ihse Bursie has updated the pull request incrementally with two > additional commits since the last revision: > > - Make the split based on the name "awt" instead, and document the reason > - Rename 2dLibraries.gmk to ClientLibraries.gmk I appreciate that the build group does a lot of work maintaining this file. I'd like to think that even though it is a build file, it is build file for the desktop module, so I have skin in this game. I am coming at it from the point of view of what makes sense (at least to me). Even if I was the maintainer of this file, working on it every day, I wouldn't think splitting it any kind of priority. So I need to be clear, if you REALLY want to do this, then I won't stop you, I just think it is the wrong thing to do. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18743#issuecomment-2059731122
