On Wed, 17 Apr 2024 12:22:10 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> I don't mind all 3, though I certainly prefer 1 and 3 over 2 (The way I see >> it, the AIX macro check is more of a message to the programmer than it is >> important to the compiler, so I prefer the options that have it. However, I >> also don't mind if we were to go the way of option 2, this is more of a >> preference thing). The fact that only 3 files need it is also surprising to >> me, and makes option 3 seem like a good fit (Again, personal preference) >> >> Magnus and Kim, what do you guys think? > > If there are just 3 files using alloca, I strongly prefer solution 3. I think > solution 1 has already been rejected by Kim. > > (Also, for the record, it was me, not Julian, who expressed dislike about the > `-Dalloca'(size)'=__builtin_alloca'(size)'` change) https://man7.org/linux/man-pages/man3/alloca.3.html sounds like solution 2 is the cleanest one ("standards conformance"). It is also the version with minimal code and which will even work with future alloca usages :-) If solution 2 has any disadvantage, I'd prefer solution 3. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1568809674
