On Wed, 17 Apr 2024 13:02:33 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> If there are just 3 files using alloca, I strongly prefer solution 3. I >> think solution 1 has already been rejected by Kim. >> >> (Also, for the record, it was me, not Julian, who expressed dislike about >> the `-Dalloca'(size)'=__builtin_alloca'(size)'` change) > > https://man7.org/linux/man-pages/man3/alloca.3.html sounds like solution 2 is > the cleanest one ("standards conformance"). It is also the version with > minimal code and which will even work with future alloca usages :-) > If solution 2 has any disadvantage, I'd prefer solution 3. I'm aware of this discussion and looking into the issues, but a personal matter has intervened and it will take me a while to respond properly. Maybe next week. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1569012102
