On Fri, 20 Dec 2024 13:20:50 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> make/hotspot/lib/CompileJvm.gmk line 139: >> >>> 137: >>> 138: ifeq ($(call isTargetCpu, riscv64), true) >>> 139: JVM_CFLAGS += $(RVV_CFLAGS) >> >> The new flag should be added to the JVM_CFLAGS at configure time. No need to >> export it to spec.gmk and do it at runtime. > > The flag is different for the build JVM and the JVM. > If I just set in configure time it seem like both OPENJDK_BUILD_JVM_CFLAGS > and JVM_CFLAGS have the flag. > Which is incorrect, as only OPENJDK_BUILD_JVM_CFLAGS in this case should have > it. > > Am I doing something wrong? I mirrored SVE_FLAGS which do this... `SVE_CFLAGS` is used to compile a separate library, libsleef. They do not have an already prepared set of flags to use, as Hotspot do. (Hotspot is the only library which has this, since it is magnitutes more complex than other libraries.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22845#discussion_r1893939455
