On Fri, 20 Dec 2024 13:51:20 GMT, Robbin Ehn <r...@openjdk.org> wrote:

>> Having different flags for the build and the target JVM is a bit more 
>> tricky, but not impossible. You just need to "hålla tungan rätt i mun". :-) 
>> 
>> In `FLAGS_SETUP_CFLAGS_CPU_DEP`, you need to add something like:
>> 
>>   if test "x$FLAGS_CPU" = xriscv64; then
>>     $1_DEFINES_CPU_JVM="$1_DEFINES_CPU_JVM $2RVV_DEFINES"
>>   fi
>
> Thanks, I'll test it.

It is written untested so it might need some tweaking. My suggestion also 
incorporated (silently) the recommendation to rename  $2RVV_FLAG to 
$2RVV_DEFINES. :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22845#discussion_r1893972756

Reply via email to