On Thu, 1 May 2025 22:46:00 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review this PR that adds a `test-linux-x64-static` job, which runs > tier1 tests on the static-jdk 'release' binary created from the > `linux-x64-static` build job in GHA. Following are the details on the changes: > > .github/actions/get-bundles/action.yml. > - Add `static-suffix` parameter. `static-suffix` is added to the bundle name. > - Add `static-jdk-path` output. > - Unpack static bundles in bundles/static-jdk. > > .github/actions/upload-bundles/action.yml > - Add `static-suffix` parameter. The `static-suffix` is added to the bundle > name. The `linux-x64-static` build job sets the parameter as "-static". In > other jobs, `static-suffix` not set. > > .github/workflows/build-linux.yml > - Pass `${{ inputs.static-suffix }}` to upload-bundles action, with the > `static-suffix` parameter. > > .github/workflows/main.yml > - Build `product-bundles test-bundles static-jdk-bundles` for > `linux-x64-static` job. > - Add `test-linux-x64-static` job. It currently tests on `release` binary and > not `debug` binary, since there are build issue with `debug` due to GHA > resource/space limit. > - Set `debug-suffix` for the existing non-static test jobs, which test on > `debug` binaries. > > .github/workflows/test.yml > - Add `debug-suffix` parameter and replace `debug-suffix: -debug` with > `debug-suffix: ${{ inputs.debug-suffix }}` in hs/tier1 tests in the test > matrix. The existing test jobs (on non-static JDK) set `debug-suffix` to > `-debug` to test on `debug` binaries. > - Add `static-suffix` parameter. Add `${{ inputs.static-suffix }}` to the > test result artifact name. > - Add `run-tests-static`. > - Add step for notifying test failures on static JDK. > > @shipilev Could you please help review this change? Thanks! .github/workflows/main.yml line 234: > 232: with: > 233: platform: linux-x64 > 234: make-target: 'product-bundles test-bundles static-jdk-bundles' This will make us build the tests and the normal JDK twice, once here and once for the normal build-linux-x64 target. That seems like a useless waste of time and computing resources. There must be a better way of doing this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24992#discussion_r2073609867