On Mon, 5 May 2025 14:55:54 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add $static_jdk_bundle_zip$static_jdk_bundle_tar_gz for bundle-found check.
>
> .github/workflows/main.yml line 367:
> 
>> 365:     name: linux-x64-static
>> 366:     needs:
>> 367:       - build-linux-x64-static
> 
> Just thinking out loud here, what if you also added ` build-linux-x64` to the 
> `needs` list. I guess that would make sure the test bundle is built before 
> trying to execute this. Then the trick will just be to get both the test 
> bundle and the static-jdk bundle downloaded...

@magicus I looked into this today. Adding `build-linux-x64` to the `needs` list 
for `test-linux-x64-static` works with additonal changes in 
.github/actions/get-bundles/action.yml to download the static bundle 
separately. I added a `download-static-bundles` step for the static bundle. 

With this, I was able to only build the `static-jdk-bundles` without 
`product-bundles test-bundles` in `build-linux-x64-static` job, as your other 
suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24992#discussion_r2085744124

Reply via email to