On Thu, 11 Sep 2025 09:27:51 GMT, Magnus Ihse Bursie <[email protected]> wrote:

>> src/java.base/windows/native/launcher/relauncher.c line 1:
>> 
>>> 1: /*
>> 
>> How did you test the relauncher for Windows? Can you remind me if static JDK 
>> is support for Windows?
>
> Yes, static JDK is supported on all supported platforms.
> 
> I just ran simple adhoc tests on the command line, checking that a select 
> subset of the launchers worked, like jar, jlink and javac. My assumption was 
> that if they just started fine, then there were no reason to test the full 
> functionality, since this patch is just about getting them launched.

Also, I've emptied the problem lists for static builds. (I kept the actual 
ProblemList files for now, if it turns out we find other tests that are 
problematic.) If there was a problem with launching e.g. `jar`, then those 
tests should have failed.

Now it has passed some time since I ran the tests, so I'll start a 
comprehensive test suite again on this PR, just to make sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24380#discussion_r2339753600

Reply via email to