On Mon, 15 Sep 2025 17:29:59 GMT, Roger Riggs <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove debug code > > src/java.base/windows/native/launcher/relauncher.c line 153: > >> 151: } >> 152: >> 153: // Our executable name (should not be quoted) > > ok here, because the full path is being explicitly passed to CreateProcess. > If the command line is to be parsed and the executable path contains a space, > CreateProcess does say it should be quoted. It would be good to have a test > case with a space in the executable path. @RogerRiggs I fixed so that the launcher name is also quoted, and verified that it works as it should. Thanks for pointing it out! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24380#discussion_r2493891717
