On Mon, 5 Jan 2026 15:51:22 GMT, Matthias Baesken <[email protected]> wrote:
> We currently expect certain files in the bin and lib folders of the jdk image. > This should be checked by a test. > For now we will probably not check for exact file lists; but certain files or > file types (like exe / pdb / so etc.) will be allowed and others not. > > See https://bugs.openjdk.org/browse/JDK-8373255 for examples of unwanted > files. The name of the test is rather vague. Is your plan to expand this to check more kinds of files in the near future? Otherwise I would like a more specific test name to avoid confusion. We are specifically checking bin and lib files in the JDK image. Also, please be ready to followup on this if corner cases are discovered for specific build configurations. Typically a test like this that makes assumptions on the layout or contents of the image will need some amount of conditionals based on the build configuration. There is a framework for this in place in case you need it. I'm thinking about various kinds of instrumented builds that may create additional files in the image. test/jdk/build/CheckFiles.java line 2: > 1: /* > 2: * Copyright (c) 2019, 2026, Oracle and/or its affiliates. All rights > reserved. This file was added this year, so the copyright shouldn't state 2019. ------------- PR Review: https://git.openjdk.org/jdk/pull/29040#pullrequestreview-3635195433 PR Review Comment: https://git.openjdk.org/jdk/pull/29040#discussion_r2668712020
