On Wed, 7 Jan 2026 14:46:44 GMT, Erik Joelsson <[email protected]> wrote:
> The name of the test is rather vague. Is your plan to expand this to check > more kinds of files in the near future? Otherwise I would like a more > specific test name to avoid confusion. We are specifically checking bin and > lib files in the JDK image. > > Also, please be ready to followup on this if corner cases are discovered for > specific build configurations. Typically a test like this that makes > assumptions on the layout or contents of the image will need some amount of > conditionals based on the build configuration. There is a framework for this > in place in case you need it. I'm thinking about various kinds of > instrumented builds that may create additional files in the image. I have at least some ideas to add more checks. E.g. if an include folder is present in the image , it should contain just headers. If a legal folder is present, there is also only a rather limited number of files 'allowed' . Regarding corner, cases - yes sure there can be some; maybe we need followup actions to handle them. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29040#issuecomment-3719252450
